Track view read sets by arg hash#5443
Merged
Merged
Conversation
joshua-spacetime
force-pushed
the
joshua/read-set-args
branch
from
64b376a to
8debb2c
Compare
Shubham8287
approved these changes
Jun 29, 2026
Shubham8287
left a comment
Shubham8287
left a comment
Contributor
There was a problem hiding this comment.
It's better direction to keep subcribers in memory.
I think we can put comment on subscription's system tables to explain, that they are deprecated and not actively inserted rows.
joshua-spacetime
force-pushed
the
joshua/read-set-args
branch
from
73c3cca to
4e5adbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removes
arg_idfrom read sets, and also moves view lifecycle management fromst_view_subinto the committed state. Trying to move away from system tables and persistent state in general for views since this has been the source of many issues.API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
Existing coverage.